Uploaded image for project: 'appNG'
  1. appNG
  2. APPNG-2448

Setting properties for HikariCPConfigurer in PlatformConfig has no effect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, 1.24.0, 1.24.1, 1.24.2, 1.24.3, 1.24.4, 1.24.5, 1.25.0
    • Fix Version/s: 1.25.0
    • Component/s: None
    • Labels:
      None

      Description

      ..since the DataSource has already been created after calling the constructor:

      		DatabaseConnection connection = new DatabaseConnection(DatabaseType.valueOf(type.toUpperCase()), jdbcUrl,
				driverClass, userName, password.getBytes(), validationQuery);
		connection.setMinConnections(minConnections);
		connection.setMaxConnections(maxConnections);
		connection.setValidationPeriod(validationPeriod);
		connection.setName("appNG ROOT connection");
		HikariCPConfigurer configurer = new HikariCPConfigurer(connection, logPerformance);
		configurer.setMaxLifetime(maxLifetime);
		configurer.setValidationTimeout(validationTimeout);
		configurer.setConnectionTimeout(connectionTimeout);
		configurer.setAutoCommit(autoCommit);
		return new DataSourceFactory(configurer);

      So this affects:

      • setMaxLifetime(maxLifetime)
      • setValidationTimeout(validationTimeout)
      • setConnectionTimeout(connectionTimeout)
      • setAutoCommit(autoCommit)

        Attachments

          Issue Links

          causes

          Bug - Existing functionality is not working as intended or documented. SCHED-54 Starting the application hangs on SQL Server

          • Medium - Has the potential to affect progress.
          • Done
          relates to

          Feature - New functionality. APPNG-2350 DatasourceConfigurer should support setting the maximum lifetime for a connection

          • Medium - Has the potential to affect progress.
          • Done

          Improvement - A (small) change to an existing functionality. APPNG-2399 HikariCPConfigurer should set autoCommit to false and allow empty/null validation query

          • Medium - Has the potential to affect progress.
          • Done

          Bug - Existing functionality is not working as intended or documented. APPNG-2414 Rework autoCommit mode

          • Medium - Has the potential to affect progress.
          • Done

            Activity

              People

              • Assignee:
                mueller.matthias Matthias Müller
                Reporter:
                mueller.matthias Matthias Müller
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: